Skip to content

Simplification in the definition of Phase 2 HLT workflows - #51142

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
SegmentLinking:tidyPhase2HLTWfs
Jun 12, 2026
Merged

Simplification in the definition of Phase 2 HLT workflows#51142
cmsbuild merged 2 commits into
cms-sw:masterfrom
SegmentLinking:tidyPhase2HLTWfs

Conversation

@VourMa

@VourMa VourMa commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This is a technical PR with the aim of updating/simplifying the Phase 2 HLT workflows in the following ways:

  • Use the @ syntax for the HLT step;
  • Change steps of the base workflow for derivative workflows instead of fully redefining them.

Some local tests passed without issue but the full relevant part of the matrix should be tested by the bot.

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

test parameters:

  • workflows = ph2_hlt

@mmusich

mmusich commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

cmsbuild commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a1fd/53737/summary.html
COMMIT: add5209
CMSSW: CMSSW_20_0_X_2026-06-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51142/53737/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 29 differences found in the comparisons
  • DQMHistoTests: Total files compared: 57
  • DQMHistoTests: Total histograms compared: 3647546
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3647488
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 56 files compared)
  • Checked 242 log files, 196 edm output root files, 57 DQM output files
  • TriggerResults: no differences found

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_20_1_X. Please open a backport if it should also go in to CMSSW_20_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 9, 2026
@mmusich

mmusich commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This branch has conflicts that must be resolved

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51142 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please check and sign again.

@VourMa

VourMa commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

This branch has conflicts that must be resolved

The conflicts have been resolved since yesterday. Could we test before more come up?

@mmusich

mmusich commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a1fd/53856/summary.html
COMMIT: e9e84b9
CMSSW: CMSSW_20_1_X_2026-06-10-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51142/53856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 57
  • DQMHistoTests: Total histograms compared: 3688981
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3688963
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 56 files compared)
  • Checked 242 log files, 196 edm output root files, 57 DQM output files

@AdrianoDee

Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 1a522b6 into cms-sw:master Jun 12, 2026
11 checks passed
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026
Simplification in the definition of Phase 2 HLT workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants